Type:		Critical Browser Incompatibility Fix
Software:	shimmie2
Module:		themes
Reference:	http://trac.shishnet.org/shimmie2/browser/branches/branch_2.2/themes/danbooru/sidebar.js
		http://trac.shishnet.org/shimmie2/browser/branches/branch_2.2/themes/default/sidebar.js
Verified:	Yes
Solved:		Yes
Official res.:	Unknown
Author:		Daniel Marschall
Date:		2008-10-20


If you are using Internet Explorer and the danbooru theme, the upload section at the upload
page WILL NOT BE VISIBLE! It is automatically toggled by the theme's onload-javascript and
cannot be un-toggled by clicking the section title (that is only possible for nav-bar-sections).

So, what's the reason?

In the script.js we see following lines:

	window.onload = function(e) {
		var sections=get_sections();
		for(var i=0;i<sections.length;i++) toggle(sections[i]);

They are telling us: At page-load, toggle all sections listed from get_sections().
Because usually all sections are visible, the sections from get_sections() will be
made invisible. (Reason?)

Now we look into sidebar.js:

	function get_sections()
	{
		var cookie=get_cookie(cookie_name);
		if(cookie) return cookie.split(/,/);
		else return default_sections;
	}

Get-Sections is reading out the user's cookies which sections are toggled and which are not
if there is no cookie set, then the constant default_sections will be returned.

Now we look at the top of the script:

	var default_sections=["upload", "edit_tags"];

And here we have the malefactor! The sections "upload" and "edit_tags" are INVISIBLE BY DEFAULT!

But since we cannot recover the visiblity of the upload section, this is absolutely crap!

Also, the whole image board do not have any section called "edit_tags", so this is also needless.

And: Why should sections be invisible by default? So we change that...

1.	Danbooru theme

~ themes/danbooru/sidebar.js

#	Find
	var default_sections=["upload", "edit_tags"];
#	Replace with
	var default_sections=[];
#	Line 6

2. Default theme

~ themes/default/sidebar.js

#	Find
	var default_sections=["upload", "edit_tags"];
#	Replace with
	var default_sections=[];
#	Line 6

Note: Here the bug makes the uploading not impossible as
contrasted with the danbooru theme. But it is also dangerous
code, so it will also removed there.


WARNING! The users have to delete their cookies and restart their browser to
see the upload-form finally! I think there is no way to solve that.